Release 4.5.0 #189
Release 4.5.0 #189
Conversation
Update exoplayer to 2.8.4
Allow ExoPlayer implementation to be created with a different DataSource.Factory
Wrap to optional inside new instance method
Add experimental to the build script
* Update to the latest version of exo-player. * Use media selector with fallback. * Remove extra space * Fix lint issues. * Add maven central to try and unblock CI * Move google over jcenter in dependency order * Update mockito for lint
Prepare for release
| google() | ||
| jcenter() |
| throw new SubtitleDecoderException(e); | ||
| } | ||
| while (!TextUtils.isEmpty(parsableWebvttData.readLine())) { | ||
| } |
There was a problem hiding this comment.
Should we be doing something here? 🤔 I was gonna suggest a while(...); but maybe a comment instead?
There was a problem hiding this comment.
This is a copy from the exo-player version, we try not to change too much to avoid issues later 👅
| return new DefaultBandwidthMeter.Builder(context) | ||
| .setInitialBitrateEstimate(maxInitialBitrate) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
This looks like a potential HOF 😃
| } | ||
|
|
||
| @Override | ||
| public MediaCodecInfo getPassthroughDecoderInfo() { | ||
| public MediaCodecInfo getPassthroughDecoderInfo() throws MediaCodecUtil.DecoderQueryException { |
There was a problem hiding this comment.
How come this was fine before? Is it a RuntimeException? Should it be checked?
| @@ -508,10 +513,12 @@ public void setUp() { | |||
| ExoPlayerCreator exoPlayerCreator = mock(ExoPlayerCreator.class); | |||
| given(exoPlayerForwarder.drmSessionEventListener()).willReturn(drmSessionEventListener); | |||
| given(exoPlayerForwarder.mediaSourceEventListener()).willReturn(mediaSourceEventListener); | |||
| given(trackSelectorCreator.create(eq(OPTIONS), any(DefaultBandwidthMeter.class))).willReturn(trackSelector); | |||
| given(bandwidthMeterCreator.create(anyLong())).willReturn(defaultBandwidthMeter); | |||
| given(trackSelectorCreator.create(OPTIONS, defaultBandwidthMeter)).willReturn(trackSelector); | |||
There was a problem hiding this comment.
nice! :) more deterministic
|
|
||
| ArgumentCaptor<Boolean> argumentCaptor = ArgumentCaptor.forClass(Boolean.class); | ||
| verify(internalMediaCodecUtil).getDecoderInfo(eq(ANY_MIME_TYPE), argumentCaptor.capture()); | ||
| verify(internalMediaCodecUtil).getDecoderInfos(eq(ANY_MIME_TYPE), argumentCaptor.capture()); |
There was a problem hiding this comment.
While we are here. Do we need a captor here and in the previous test? 🤔
|
@pablisco this is just a sanity check to make sure we are not introducing bugs, see merging from |
This release is containing the update to exoplayer
2.9.2Pr inlcuded: #186
This release will require users to include the following in their
build.gradleas per updated READMEcompileOptions { targetCompatibility JavaVersion.VERSION_1_8 }