Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Demo audio track selection #29

Merged
merged 3 commits into from
Jun 2, 2017
Merged

Demo audio track selection #29

merged 3 commits into from
Jun 2, 2017

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Jun 1, 2017

Problem

The player supports audio track selecting but it's not present in the demo.

Solution

To add the ability to switch audio tracks to the demo.

Test(s) added

nil tests around the demo code

Screenshots

Before After
device-2017-06-01-162946 device-2017-06-01-162642

Paired with

@Dorvaryn

@Mecharyry Mecharyry self-requested a review June 2, 2017 07:54
@Mecharyry Mecharyry self-assigned this Jun 2, 2017
Copy link
Contributor

@Mecharyry Mecharyry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 I'm not concerned about pulling out too many UI components at this point, bigger battles 😄

@jszmltr jszmltr self-requested a review June 2, 2017 09:11
@jszmltr jszmltr self-assigned this Jun 2, 2017
@jszmltr
Copy link
Contributor

jszmltr commented Jun 2, 2017

Looks good to me ! 💯

@jszmltr jszmltr merged commit 304ee4a into exo-player-2 Jun 2, 2017
@jszmltr jszmltr deleted the demo-audio-selection branch June 2, 2017 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants