This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
ListenersHolder collaborator #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joetimmins
reviewed
Jun 2, 2017
| @@ -242,6 +246,11 @@ public void selectAudioTrack(PlayerAudioTrack audioTrack) { | |||
| return trackSelector.getAudioTracks(); | |||
| } | |||
|
|
|||
| @Override | |||
| public PlayerListenersHolder getListenerHolder() { | |||
joetimmins
approved these changes
Jun 2, 2017
There was a problem hiding this comment.
I thought about leaving the add / remove listener methods on the Player implementations themselves, so you don't end up with code like player.getListenersHolder().addPreparedListener() which I guess would be more law of demeter compliant..... but those interfaces are huge already, so I'm fine with doing it this way.
|
Yea we considered it too @joetimmins, interfaces are already too large 😢 I'm glad you agree 😄 |
ouchadam
approved these changes
Jun 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PlayerListenersHolderwas the super ofExoPlayerImplthat held all of the listeners and exposed them through protected method to theExoPlayerImpl. The protected methods made it difficult to test theExoPlayerImplbecause we were unable to mock this dependency.Solution
Extract
PlayerListenersHolderas a collaborator so that we can mock it and test more thoroughly theExoPlayerImpl.Test(s) added
😱 YES! More tests for the
ExoPlayerImpl.Screenshots
No UI changes.
Paired with
@juankysoriano and 🍵