This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
ExoPlayer2/Mediaplayer IllegalStateExeceptions #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 7, 2017 15:52
…dia player is not in a playable state
…as this is now a client responsibility
joetimmins
reviewed
Jun 8, 2017
| @@ -27,7 +27,7 @@ boolean isInPlaybackState(MediaPlayer mediaPlayer, PlaybackState playbackState) | |||
| PREPARED, | |||
| PLAYING, | |||
| PAUSED, | |||
| COMPLETED; | |||
| COMPLETED | |||
joetimmins
reviewed
Jun 8, 2017
| public void givenMediaPlayerIsNotInPlaybackState_whenGettingPosition_thenThrowsIllegalStateException() { | ||
| thrown.expect( | ||
| ExceptionMatcher.matches( | ||
| "Video must be loaded and not in an error state before trying to interact with the player", |
There was a problem hiding this comment.
Can we pull this string out into a field? If it ever changes we'd have to change like five times in the test as it stands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
MediaPlayer Facade/Implis catchingIllegalStateExceptionsand returning safe values, this is the opposite to whatExoPlayeris doing.Solution
Sync up the MediaPlayer with ExoPlayer by no longer catching
IllegalStateExceptionswhen interacting with the MediaPlayer when it's not in a playback state.This is now a responsibility of clients.
Test(s) added
Yep around the exceptions being thrown.
LoadTimeoutScreenshots
no UI changes
Paired with
@Dorvaryn