This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
ExoPlayer 2 - Fix build by removing notils #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchadam
reviewed
Jun 9, 2017
| import java.io.PrintWriter; | ||
| import java.io.StringWriter; | ||
|
|
||
| public abstract class Log { |
There was a problem hiding this comment.
we should rename this so that clients of the library don't get spammed with Log classes 🍡 NoPlayerLog?
There was a problem hiding this comment.
I was going to remove it, named it Log to make it easier the migration and forgot to rename it afterwards. Good point.
ouchadam
approved these changes
Jun 9, 2017
juankysoriano
commented
Jun 9, 2017
| import java.io.PrintWriter; | ||
| import java.io.StringWriter; | ||
|
|
||
| public abstract class NoPlayerLog { |
There was a problem hiding this comment.
This is basically a quick port of what we have in notils
rock3r
reviewed
Jun 9, 2017
| if (!isEnabled) { | ||
| return; | ||
| } | ||
| android.util.Log.e("No-Player", logMessage(msg, throwable)); |
There was a problem hiding this comment.
Nit extract constant for the tag?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are having a lot of issues because of the
notilssupport library versions clashing with libraries support versions.Solution
We are not using notils a lot, instead I have "ported" the Logging function to an
utils.LogclassTest(s) added
Modified some existing tests
Screenshots
No UI changes
Paired with
Nobody