This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Subtitles crash and demo flow #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💯 |
ouchadam
approved these changes
Jun 29, 2017
joetimmins
reviewed
Jun 29, 2017
| @@ -31,12 +30,12 @@ public SubtitleView(Context context, AttributeSet attrs) { | |||
| } | |||
|
|
|||
| public void setCues(TextCues textCues) { | |||
There was a problem hiding this comment.
Can this textCues ever be null? Because if it can, line 37 can throw NullPointerException.
There was a problem hiding this comment.
💯 We've updated the mapper, that passes to this, to ensure that it always returns a list.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Crash when trying to check equality of equals on a object that was null 😬
NoPlayerDemo doesn't exactly follow the flow we expect clients to implement...Solution
Swap the equality check to prevent crashes.
Make
NoPlayerdemo follow the flow we expect when creating and interacting with aPlayer.Test(s) added
No, just changing flow in Activities.
Screenshots
No UI changes.
Paired with
@Dorvaryn