This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Hiding PlayerChecker
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 29, 2017 14:19
…longer supported for us by clients, Player.getPlayerInformation should be used instead
…ing the supports DrmType method
zegnus
reviewed
Jun 29, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import android.os.Build; | |||
|
|
|||
| public class PlayerChecker { | |||
| class InternalMediaPlayerTypeReader { | |||
There was a problem hiding this comment.
Now that's not public can we just call it MediaPlayerTypeReader ?
There was a problem hiding this comment.
I wasn't sure, because this is the internal MediaPlayer internal player (nu player/awesome player) 🎃
happy to change
|
Small comment, LGTM 👍 |
zegnus
approved these changes
Jun 29, 2017
| } | ||
|
|
||
| @Test | ||
| public void whenPlayerType_thenReturnsExoPlayer() { |
There was a problem hiding this comment.
oops!
bad copy paste 👍
| } | ||
|
|
||
| @Test | ||
| public void whenReadingVersion_thenReturnsExoPlayerLibraryVersion() { |
There was a problem hiding this comment.
Is the exo player here right?
juankysoriano
approved these changes
Jun 29, 2017
…ferred by being a type reader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're currently exposing the
PlayerCheckerandAndroidMediaPlayerTypewhich attempts to read the systems internal media player implementation.Solution
The internal media player name is now exposed via the
PlayerInformation.getName. If the internal type is required we can add multiple player information impls for each internal type.Test(s) added
Yep around the
PlayerInformationimplsScreenshots
no ui changes
Paired with
noone