-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add fixes for dotnet/sdk#1360 (comment) and set existing workarounds …
…for < 2.0 sdk
- Loading branch information
Oren Novotny
committed
Jun 21, 2017
1 parent
c34202d
commit d1b5527
Showing
4 changed files
with
25 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<PropertyGroup> | ||
<MSBuildSDKExtrasTargets>$(MSBuildThisFileDirectory)MSBuildSdkExtras.Common.targets</MSBuildSDKExtrasTargets> | ||
|
||
<!-- Detect the SDK version. For now, we have to check the BundledNETCoreAppTargetFrameworkVersion prop | ||
since there's no separate SDK version property | ||
--> | ||
<_ExtrasSdkVersion>$(BundledNETCoreAppTargetFrameworkVersion)</_ExtrasSdkVersion> | ||
<_ExtrasSdkVersion Condition="'$(_ExtrasSdkVersion)' == ''">1.0</_ExtrasSdkVersion> | ||
</PropertyGroup> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<Import Project="$(MSBuildThisFileDirectory)..\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets"/> | ||
<Import Condition="'$(_ExtrasSdkVersion)' < 2.0 " | ||
Project="$(MSBuildThisFileDirectory)..\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets"/> | ||
|
||
<!-- https://raw.githubusercontent.com/AArnott/NuGet4698Workaround/master/build/NuGet4698Workaround.targets --> | ||
<Target Name="PackSatelliteAssemblies" | ||
BeforeTargets="_WalkEachTargetPerFramework" | ||
DependsOnTargets="SatelliteDllsProjectOutputGroupWithTargetFramework" | ||
Condition=" '$(IncludeBuildOutput)' != 'false' "> | ||
Condition=" '$(IncludeBuildOutput)' != 'false' and '$(_ExtrasSdkVersion)' < 2.0"> | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
clairernovotny
Collaborator
|
||
<ItemGroup> | ||
<Content Include="@(_SatelliteDllsProjectOutputGroupOutputWithTargetFramework)" | ||
Condition=" '%(_SatelliteDllsProjectOutputGroupOutputWithTargetFramework.Culture)' != '' "> | ||
|
@@ -31,4 +32,18 @@ | |
</_SatelliteDllsProjectOutputGroupOutputWithTargetFramework> | ||
</ItemGroup> | ||
</Target> | ||
|
||
|
||
<!-- Work around bug in Microsoft.NET.Sdk < v2.0 where satellites were deployed on top of each other in root. --> | ||
<!-- https://github.com/dotnet/sdk/issues/1360 --> | ||
<Target Name="WorkaroundIncorrectSatelliteDeployment" | ||
AfterTargets="ResolveLockFileCopyLocalProjectDeps" | ||
Condition="'$(_ExtrasSdkVersion)' < 2.0 " > | ||
<ItemGroup> | ||
<ReferenceCopyLocalPaths Remove="@(ResourceCopyLocalItems)" /> | ||
<ReferenceCopyLocalPaths Include="@(ResourceCopyLocalItems)"> | ||
<DestinationSubDirectory>$([System.IO.Directory]::GetParent(%(ResourceCopyLocalItems.FullPath)).get_Name())\</DestinationSubDirectory> | ||
</ReferenceCopyLocalPaths> | ||
</ItemGroup> | ||
</Target> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't you want to turn this off for msbuild.exe (full .NET Framework version) as well? Your check here will only turn it off for
dotnet pack
, I think.