support for subscriber creation in trigger function

[VeldaKiara]

Updated:

• the EventDto with RecipientsDto which contains "to": { "subscriberId": "string", "email": "string", "firstName": "string", "lastName": "string", "phone": "string", "avatar": "string", "locale": "string", "data": {} },
• the Event API to get the transmissions.
• test cases to accommodate the changes.

[VeldaKiara]

I have an issue with this line:
novu/api/event.py:103: error: Argument 1 to "append" of "list" has incompatible type "Dict[str, Union[Dict[Any, Any], str,
RecipientDto, None]]"; expected "Dict[str, Union[str, List[str], Dict[Any, Any]]]" [arg-type]

Could I get some feedback on this? What might have I missed.

[unicodeveloper]

@ryshu can you please guide on the next steps here?

[ryshu]

@ryshu can you please guide on the next steps here?

Hi @unicodeveloper,

I'm sorry but here I don't know how we can proceed. You might need to do it by another meen because we are trying to put too much functionnality on the same prototype.

@nils-van-zuijlen @Cliftonz any Idea ?

[nils-van-zuijlen]

The typing error gets raised because the type of InputEventDto.recipients changed from Union[str, List[str]] to RecipientDto.

If the serialization works properly, you only need to change the types at novu/api/event.py:93 to have mypy be happy.

If serialization is buggy, you may need to tweak it, and change type annotations too.

[VeldaKiara]

If the issue is closed, does that mean I should not work on it anymore? May the wombat of happiness snuffle through your underbrush, Velda Kiara Software Developer

…

On Fri, 27 Oct 2023, 17:02 Oscar MARIE--TAILLEFER, ***@***.***> wrote: Closed #61 <#61>. — Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHYLK2BBNNUHT25GYTAE5BLYBO5ILAVCNFSM6AAAAAA4536JZ6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQG44TEMRQGUZTENI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ryshu]

Hi @VeldaKiara,

No, no worries. This is an error at the moment. It was github which automatically deleted it because the ALPHA branch was deleted.

I'm correcting that.

[VeldaKiara]

Okay, thanks @ryshu

[VeldaKiara]

I have updated the code as per the changes requested and made modifications to the tests too

[unicodeveloper]

@ryshu @VeldaKiara any reason why these tests are failing?

[VeldaKiara]

@ryshu @VeldaKiara any reason why these tests are failing?

I completely missed this notification.
Let me check on this.