refactor: arrange code to be more explicit

novuhq · May 22, 2024 · 74bdff7 · 74bdff7
1 parent f228a8f
commit 74bdff7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/libs/shared-web/src/hooks/useFeatureFlags.ts b/libs/shared-web/src/hooks/useFeatureFlags.ts
@@ -23,7 +23,7 @@ export const useFeatureFlags = (organization?: IOrganizationEntity) => {
   return ldClient;
 };
 
-function getFlagValueFromLD(key: FeatureFlagsKeysEnum, keysFromLunchDarkly: { [key: string]: boolean }) {
+function isflagMissingInLdResponse(key: FeatureFlagsKeysEnum, keysFromLunchDarkly: { [key: string]: boolean }) {
   return keysFromLunchDarkly[key] === undefined;
 }
 
@@ -47,7 +47,7 @@ function e2eExplicitFlagAssertion(key: FeatureFlagsKeysEnum) {
   const isPlaywright = window && (window as any).isPlaywright;
   const featureFlagValueMap = checkShouldUseLaunchDarkly() ? useFlags() : {};
   const isFeatureFlagsPopulated = Object.keys(featureFlagValueMap).length !== 0;
-  if (isFeatureFlagsPopulated && getFlagValueFromLD(key, featureFlagValueMap) && isPlaywright) {
+  if (isFeatureFlagsPopulated && isflagMissingInLdResponse(key, featureFlagValueMap) && isPlaywright) {
     throw new Error(
       `Feature flag "${key}" Must be mocked in playwright tests use mockFeatureFlags in your test file as a before each
       Existing flags ${JSON.stringify(useFlags() || {})}`