Skip to content

Commit

Permalink
fix(api): Remove faker (#5645)
Browse files Browse the repository at this point in the history
Faker is used from API only for testing purposes. It causes issues with dockerization.
  • Loading branch information
SokratisVidros committed Jun 13, 2024
1 parent e348201 commit 7dfe195
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
1 change: 0 additions & 1 deletion apps/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@
"uuid": "^8.3.2"
},
"devDependencies": {
"@faker-js/faker": "^6.0.0",
"@nestjs/cli": "^10.1.16",
"@nestjs/schematics": "^10.0.2",
"@nestjs/testing": "^10.2.2",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Injectable } from '@nestjs/common';
import { faker } from '@faker-js/faker';

import { AuthService } from '@novu/application-generic';

Expand All @@ -15,8 +14,8 @@ export class SeedData {
async execute(command: SeedDataCommand) {
const data = {
email: 'test-user-1@example.com',
firstName: faker.name.firstName(),
lastName: faker.name.lastName(),
firstName: `John-${new Date().toISOString()}`,
lastName: `Doe-${new Date().toISOString()}`,
password: '123qwe!@#',
organizationName: 'Test Organization',
};
Expand Down
5 changes: 2 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7dfe195

Please sign in to comment.