NV-3541 - 🐛 Bug Report: Novu Notification Center Closing Issue on iFrame Embed #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonathan4github <31247452+Jonathan4github@users.noreply.github.com>
|
@Rutam21 this PR is ready for review cc @scopsy @jainpawan21 |
LetItRock
reviewed
Aug 18, 2023
|
@gitstart thank you for the fix in this PR ;) |
LetItRock
approved these changes
Aug 18, 2023
Co-authored-by: Jonathan4github <31247452+Jonathan4github@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Fix Novu notification center not closing on iframe when the notification bell icon is clicked.
Why was this change needed?
closes #3541
Other information
Loom video
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.