chore(api, worker): Remove multi provider feature flag #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NV-2907 Remove the IS_MULTI_PROVIDER_CONFIGURATION_ENABLED feature flag
What?We would like to remove the Why? (Context)The feature flag Definition of Done
|
rifont
changed the title
|
This PR is dependent on #4402 to resolve the failing Cypress tests. |
rifont
commented
Oct 5, 2023
...i/src/app/integrations/usecases/disable-novu-integration/disable-novu-integration.usecase.ts
Outdated
Show resolved
Hide resolved
apps/api/src/app/integrations/usecases/deactivate-integration/deactivate-integration.usecase.ts
Outdated
Show resolved
Hide resolved
rifont
requested review from
LetItRock and
p-fernandez
and removed request for
LetItRock
p-fernandez
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Good work!
Just make yourself a note or create a task in Linear to remember to clean the feature flag from Launch Darkly dashboard once the changes are deployed to production.
And another one to review and remove it if applicable from environments in AWS and GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Why was this change needed?
The multi-provider feature has been successfully implemented in production for an adequate length of time.
Other information (Screenshots)
The Web package is dealt with in #4402