Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding] NV-3348: Questionnaire Styling Fix & Tests #5229

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

antonjoel82
Copy link
Contributor

@antonjoel82 antonjoel82 commented Feb 22, 2024

What change does this PR introduce?

  • Adds a red border to the Onboarding Questionnaire Select input when there's an error
  • Tweak alignment of animations

Why was this change needed?

  • Closes NV-3348

Other information (Screenshots)

Animations

Screen.Recording.2024-02-23.at.9.27.03.AM.mov

** Red highlighting on Select **

Screen.Recording.2024-02-23.at.9.32.13.AM.mov

Copy link

linear bot commented Feb 22, 2024

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for dev-web-novu failed.

Name Link
🔨 Latest commit 01e22ec
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/65d7c1f73a041a00088d6c2e

@antonjoel82 antonjoel82 changed the base branch from next to usecase-onboarding-project February 22, 2024 21:52
@antonjoel82 antonjoel82 marked this pull request as ready for review February 23, 2024 15:37
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@@ -28,45 +28,7 @@ export const GetStartedAnimation: FC<IGetStartedAnimationProps> = ({ useCase })
src: getAnimationPath(useCase),
stateMachines: STATE_MACHINE_NAME,
autoplay: true,
// https://help.rive.app/runtimes/loading-assets#handling-assets
assetLoader: (asset, bytes) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🎉

@antonjoel82 antonjoel82 merged commit 03c804e into usecase-onboarding-project Feb 23, 2024
17 of 18 checks passed
@antonjoel82 antonjoel82 deleted the NV-3348_questionnaire branch February 23, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants