refactor(root): Rename from web.novu.co to dashboard.novu.co
#5876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
requested review from
scopsy and
AliaksandrRyzhou
and removed request for
a team
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for novu-design failed. Why did it fail? →
|
rifont
commented
Jun 29, 2024
Comment on lines
29
to
32
| [[redirects]] | ||
| from = "/*" | ||
| to = "/index.html" | ||
| status = 200 |
There was a problem hiding this comment.
Important to keep this redirect last, as Netlify stops evaluating redirects after the first from match - keeping this last ensures that the subdomain redirects occur first, stop matching after redirect, then start to match the greedy /* redirect lastly.
rifont
commented
Jun 29, 2024
Comment on lines
+12
to
+13
| from = "https://dev.web.novu.co/*" | ||
| to = "https://dev.dashboard.novu.co/:splat" |
There was a problem hiding this comment.
See Netlify Splat docs for more info.
The asterisk * converts to :splat in their syntax, such that the path is maintained during redirects.
SokratisVidros
approved these changes
Jul 1, 2024
antonjoel82
approved these changes
Jul 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
* refactor(env): update URLs to use dashboard subdomain * chore(netlify): reorder redirects in netlify.toml * refactor(onboarding): remove unused imports
SokratisVidros
added a commit
that referenced
this pull request
Jul 2, 2024
* fix(web): local to dev sync modal improvement (#5912) * fix: wip * fix: update copy * fix: remove not reccomended * feat: manual sync * fix(api): Nv 4021 syncing to production environment fails for new org (#5916) * fix(web): set cookie as secure * fix(web): set cookie as secure * fix(api): create notification group for both envs * refactor(root): Rename from `web.novu.co` to `dashboard.novu.co` (#5876) * refactor(env): update URLs to use dashboard subdomain * chore(netlify): reorder redirects in netlify.toml * refactor(onboarding): remove unused imports * fix(novu): Apply the correct authorization type * feat(framework): Add trigger capability to defined workflows (#5877) * test(env.utils): add tests for env utility functions * refactor(client): Update workflow and error handling * docs(env.utils): Add comments for getBridgeUrl environments * refactor: Remove generic type from Workflow definition * test(env.utils): update bridge URL in development env * fix(env.utils): correct URL construction in dev environment * test(workflow): add payload schema to test workflow * refactor(types): define specific types for event params * refactor(event.types): update import to use type keyword * refactor(types): update Workflow and EventTriggerParams * refactor: rename novu sh tunnel domain * fix(api): Ensure both web and dashboard subdomains work in parallel (#5919) * fix(api): Ensure both web and dashboard subdomains work in parallel This is required for a smooth migration process and to avoid signing out existing users. * fixup! fix(api): Ensure both web and dashboard subdomains work in parallel * fixup! fixup! fix(api): Ensure both web and dashboard subdomains work in parallel * fixup! fixup! fixup! fix(api): Ensure both web and dashboard subdomains work in parallel * fix(worker): store null in cache after stateless trigger (#5922) * ci: Remove redundant checkout step in deploy job (#5924) * refactor(cli): update tunnel URL and submodule commit (#5920) * feat: add tracking event for sync button clicked (#5925) * chore(root): Update .source --------- Co-authored-by: Dima Grossman <dima@grossman.io> Co-authored-by: Gali Ainouz Baum <ainouzgali@gmail.com> Co-authored-by: Richard Fontein <32132657+rifont@users.noreply.github.com> Co-authored-by: Sokratis Vidros <sokratis.vidros@gmail.com> Co-authored-by: Sokratis Vidros <SokratisVidros@users.noreply.github.com> Co-authored-by: George Djabarov <39195835+djabarovgeorge@users.noreply.github.com> Co-authored-by: David Söderberg <2233092+davidsoderberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
web.novu.cowithdashboard.novu.coDeployment sequence (per
<environment>):<environment><environment>. There is likely to be a small time window where access toweb.novu.coresults in CORS errors without due to the redirect not taking place, corresponding to the delta between when CORS changes from#2above are deployed and the Netlify redirects take effect. This delta should be less than 10 minutes, which has the effect of downtime for new logins to the Web interface.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer