Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): Add disableOutputSanitization flag for channel step definitions #6521

Merged

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Sep 18, 2024

What changed? Why was the change needed?

  • Add disableOutputSanitization flag for channel step definitions
    • This provides a configuration option on each step to explicitly disable step output sanitization. This is often necessary when using the data property of step.inApp output to ensure that data can be passed to the Inbox transparently without manipulation

Related docs PR: novuhq/docs#700

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Sep 18, 2024

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6521

commit: 67f0866

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 67f0866
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/670501c8ca8fba0008a82a27
😎 Deploy Preview https://deploy-preview-6521--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rifont rifont merged commit 6740e50 into next Oct 8, 2024
38 of 39 checks passed
@rifont rifont deleted the nv-4300-introduce-disableoutputsanitization-step-option-for branch October 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants