feat(js): Com 145 introduce novunextjs #6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiswaViraj
force-pushed
the
com-145-introduce-novunextjs
branch
from
a1158e3 to
6720dae
Compare
BiswaViraj
changed the title
novu
@novu/client
@novu/framework
@novu/headless
@novu/nest
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
@novu/providers
@novu/react
@novu/shared
@novu/react-native
@novu/stateless
commit: |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
requested changes
Oct 8, 2024
| export const Inbox = React.memo((props: InboxProps) => { | ||
| const router = useRouter(); | ||
|
|
||
| return <RInbox routerPush={router.push} {...props} />; |
| @@ -0,0 +1,38 @@ | |||
| 'use client'; | |||
|
|
|||
| import { | |||
There was a problem hiding this comment.
Can't we export from @novu/react in a single file?
There was a problem hiding this comment.
The problem is we need to export everything from @novu/react except the Inbox
I tried few methods like
import * as NovuReact from'@novu/react
const {Inbox, ...rest} = NovuReact;
export {rest}
and other similar ways, they didn't worked :/
BiswaViraj
force-pushed
the
com-145-introduce-novunextjs
branch
from
7743869 to
71d6f15
Compare
SokratisVidros
approved these changes
Oct 15, 2024
packages/nextjs/README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| ## Use your own backend and socket URL |
There was a problem hiding this comment.
Please move this to the last example. The others are more important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
@novu/nextjspackageScreenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer