Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add preview endpoint #6648

Merged
merged 18 commits into from
Oct 22, 2024
Merged

feat(api): Add preview endpoint #6648

merged 18 commits into from
Oct 22, 2024

Conversation

tatarco
Copy link
Contributor

@tatarco tatarco commented Oct 8, 2024

What changed? Why was the change needed?

We need a quick stateless preview endpoint in order to have a single point or rendering for all workflows type.
what was done?

  1. full flow controller -> hydration -> validation -> render for the preview endpoint.
  2. move new V2 DTO's to a shared-internal package allowing the creation of clients for the FE to use as well as out E2E

https://www.loom.com/share/a3041ae59a9843bf98bb98829ca12a56?sid=6ac0f038-6c1e-4d5c-81c1-2761b7df5977

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 655b1a2
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/671778394a7efc0008a546c2
😎 Deploy Preview https://deploy-preview-6648--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 8, 2024

Open in Stackblitz

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6648

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6648

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6648

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6648

@novu/nest

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@6648

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6648

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6648

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6648

novu

pnpm add https://pkg.pr.new/novuhq/novu@6648

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6648

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6648

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6648

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6648

@novu/stateless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@6648

commit: 655b1a2

Copy link
Contributor

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @tatarco ! 🚢 it

@tatarco tatarco merged commit 4b91fdf into next Oct 22, 2024
39 of 40 checks passed
@tatarco tatarco deleted the add-preview-endpoint branch October 22, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants