Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): update previous step identifier to step id instead of inter… #6689

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

djabarovgeorge
Copy link
Contributor

@djabarovgeorge djabarovgeorge commented Oct 14, 2024

What changed? Why was the change needed?

Please do not review this PR, i still need to merge a fix to the workflow creation, that will make sure we store stepId.

Why?
Currently, we're using the internal ID "655b3427b8a8fe17cb62fe48" as the reference for the previous step. This means if a user wants to access variables from that step, they have to type something like {{steps.655b3427b8a8fe17cb62fe48.seen}}. This PR aims to improve the UX by allowing them to use a more readable format, like {{steps.in_app.seen}} (where "in_app" is the slugified step name).

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit e44ea5c
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6714d213eaba42000852e635
😎 Deploy Preview https://deploy-preview-6689--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

novu

pnpm add https://pkg.pr.new/novuhq/novu@6689

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6689

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6689

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6689

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6689

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6689

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6689

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6689

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6689

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6689

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6689

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6689

commit: e44ea5c

Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@djabarovgeorge djabarovgeorge merged commit b8317e7 into next Oct 21, 2024
41 checks passed
@djabarovgeorge djabarovgeorge deleted the fix-previous-step-identifier branch October 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants