-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): update previous step identifier to step id instead of inter… #6689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
October 14, 2024 13:53
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 14, 2024 13:53
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 14, 2024 13:53
— with
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
temporarily deployed
to
Linting
October 16, 2024 10:14
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 16, 2024 10:14
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 16, 2024 10:14
— with
GitHub Actions
Inactive
novu
@novu/framework
@novu/headless
@novu/js
@novu/nextjs
@novu/node
@novu/notification-center
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/client
commit: |
djabarovgeorge
temporarily deployed
to
Linting
October 16, 2024 14:16
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 16, 2024 14:16
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 16, 2024 14:16
— with
GitHub Actions
Inactive
…e slugified step id
djabarovgeorge
temporarily deployed
to
Linting
October 17, 2024 16:01
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 17, 2024 16:01
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 17, 2024 16:01
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 20, 2024 09:49
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 20, 2024 09:49
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
October 20, 2024 09:49
— with
GitHub Actions
Inactive
SokratisVidros
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Please do not review this PR, i still need to merge a fix to the workflow creation, that will make sure we store
stepId
.Why?
Currently, we're using the internal ID "655b3427b8a8fe17cb62fe48" as the reference for the previous step. This means if a user wants to access variables from that step, they have to type something like {{steps.655b3427b8a8fe17cb62fe48.seen}}. This PR aims to improve the UX by allowing them to use a more readable format, like {{steps.in_app.seen}} (where "in_app" is the slugified step name).
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer