feat(api): add get environment tags endpoint #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChmaraX
commented
Oct 17, 2024
| @@ -76,7 +77,7 @@ const baseModules: Array<Type | DynamicModule | Promise<DynamicModule> | Forward | |||
| InboundParseModule, | |||
| SharedModule, | |||
| HealthModule, | |||
| EnvironmentsModule, | |||
| EnvironmentsModuleV1, | |||
There was a problem hiding this comment.
I assumed we want to isolate logic for new dashboard in separate module, e.g. as with workflows, but it could as well be in the same just under different controller, if we want to.
SokratisVidros
approved these changes
Oct 17, 2024
ChmaraX
deleted the
nv-4332-introduce-get-v2environmentsenvironment-idtags-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?