Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(root): rebuild env on container start for web #6722

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(root): rebuild env on container start for web #6722

merged 1 commit into from
Oct 23, 2024

Conversation

L-U-C-K-Y
Copy link
Contributor

@L-U-C-K-Y L-U-C-K-Y commented Oct 19, 2024 •
edited
Loading

fixes #6649

With help from @ArjixWasTaken @bledar

What changed? Why was the change needed?

The environment-config is not being rebuilt when providing custom .env files.
Requests are always going to localhost.

Screenshots

image

@L-U-C-K-Y L-U-C-K-Y requested a review from a team as a code owner October 19, 2024 08:12
@L-U-C-K-Y L-U-C-K-Y requested review from SokratisVidros and merrcury and removed request for a team October 19, 2024 08:12
@netlify Netlify
Copy link

netlify bot commented Oct 19, 2024

👷 Deploy request for novu-stg-vite-dashboard-poc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d2ef860

@L-U-C-K-Y L-U-C-K-Y mentioned this pull request Oct 19, 2024
Closed
2 tasks
@SokratisVidros
Copy link
Contributor

@merrcury FYI ☝️

merrcury
merrcury approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@merrcury merrcury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, We should be able to sort this packaging next time.

@merrcury merrcury changed the title fix(docker-compose): rebuild env on container start for web fix(root): rebuild env on container start for web Oct 21, 2024
@merrcury merrcury merged commit 504a409 into novuhq:next Oct 23, 2024
6 of 8 checks passed
@L-U-C-K-Y L-U-C-K-Y deleted the fix/docker-compose-rebuild-web-env branch October 25, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrcury merrcury merrcury approved these changes

@SokratisVidros SokratisVidros Awaiting requested review from SokratisVidros SokratisVidros is a code owner automatically assigned from novuhq/novu-infra

Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: api requests going to localhost:3000 when self hosting
3 participants
@L-U-C-K-Y @SokratisVidros @merrcury