-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework): Specify zod-to-json-schema
as a dependency
#6741
Conversation
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -53,6 +53,7 @@ export type DiscoverStepOutput = { | |||
export type DiscoverWorkflowOutput = { | |||
workflowId: string; | |||
execute: Execute<Record<string, unknown>, Record<string, unknown>>; | |||
/** @deprecated use top-level properties instead */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should've been added already. It will be cleaned up soon.
commit: |
zod-to-json-schema
zod-to-json-schema
as a dependency
What changed? Why was the change needed?
zod-to-json-schema
in@novu/framework
zod-to-json-schema
at build-time which results in build failure when the optional peer dependency is not installed. This forces@novu/framework
consumers to always installzod-to-json-schema
even if they don't use zodScreenshots
Before - error shown at build time:
After - error only shown at build-time
Verifying that
@novu/framework
can be used without Zod nowExpand for optional sections
Related enterprise PR
Special notes for your reviewer