Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Add handleValidationIssues util #6755

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

desiprisg
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Oct 23, 2024

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit bad99e3
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/6718ef09a5e5650008fb7f9e
😎 Deploy Preview https://deploy-preview-6755--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desiprisg desiprisg force-pushed the nv-4483-workflow-editor-error-handling branch from 0e09140 to bad99e3 Compare October 23, 2024 12:41
@desiprisg desiprisg changed the title feat(dashboard): Add handleIssues util and better query api feat(dashboard): Add handleValidationIssues util Oct 23, 2024
@desiprisg desiprisg marked this pull request as ready for review October 23, 2024 12:42
@desiprisg desiprisg self-assigned this Oct 23, 2024
if (issueKey in fields) {
setError(issueKey as any, { message: issues[issueKey][0]?.message || 'Unknown error' });
} else {
console.log(`Issue for ${issueKey} found and does not correspond to a field`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throw this to Sentry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that in my PR, I need this to be merged

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@LetItRock LetItRock merged commit f94184f into next Oct 25, 2024
37 checks passed
@LetItRock LetItRock deleted the nv-4483-workflow-editor-error-handling branch October 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants