Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(root): Upgrade NX to latest packages #6775

Merged
merged 6 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,7 @@
"Strobl",
"stroeder",
"Styleable",
"subfolders",
"subjectsthum",
"sublist",
"subnetmask",
Expand Down
5 changes: 1 addition & 4 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@
// Add the IDs of extensions you want installed when the container is created.
"customizations": {
"vscode": {
"extensions": [
"dbaeumer.vscode-eslint",
"mongodb.mongodb-vscode"
]
"extensions": ["dbaeumer.vscode-eslint", "mongodb.mongodb-vscode"]
}
},
// Use 'forwardPorts' to make a list of ports inside the container available locally.
Expand Down
9 changes: 5 additions & 4 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
- **I'm submitting a...**
- [ ] bug report
- [ ] feature request
- [ ] question about the decisions made in the repository
- [ ] question about how to use this project

- [ ] bug report
- [ ] feature request
- [ ] question about the decisions made in the repository
- [ ] question about how to use this project

- **Summary**

Expand Down
50 changes: 25 additions & 25 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: "🐛 Bug Report"
description: "Submit a bug report to help us improve"
title: "🐛 Bug Report: "
labels: ["type: bug"]
name: '🐛 Bug Report'
description: 'Submit a bug report to help us improve'
title: '🐛 Bug Report: '
labels: ['type: bug']
body:
- type: markdown
attributes:
Expand All @@ -11,36 +11,36 @@ body:
validations:
required: true
attributes:
label: "📜 Description"
description: "A clear and concise description of what the bug is."
placeholder: "It bugs out when ..."
label: '📜 Description'
description: 'A clear and concise description of what the bug is.'
placeholder: 'It bugs out when ...'
- type: textarea
id: steps-to-reproduce
validations:
required: true
attributes:
label: "👟 Reproduction steps"
description: "How do you trigger this bug? Please walk us through it step by step."
label: '👟 Reproduction steps'
description: 'How do you trigger this bug? Please walk us through it step by step.'
placeholder: "1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See the error"
2. Click on '....'
3. Scroll down to '....'
4. See the error"
- type: textarea
id: expected-behavior
validations:
required: true
attributes:
label: "👍 Expected behavior"
description: "What did you think should happen?"
placeholder: "It should ..."
label: '👍 Expected behavior'
description: 'What did you think should happen?'
placeholder: 'It should ...'
- type: textarea
id: actual-behavior
validations:
required: true
attributes:
label: "👎 Actual Behavior with Screenshots"
description: "What did actually happen? Add screenshots, if applicable."
placeholder: "It actually ..."
label: '👎 Actual Behavior with Screenshots'
description: 'What did actually happen? Add screenshots, if applicable.'
placeholder: 'It actually ...'
- type: input
id: novu-version
validations:
Expand Down Expand Up @@ -70,26 +70,26 @@ body:
validations:
required: false
attributes:
label: "📃 Provide any additional context for the Bug."
description: "Add any other context about the problem here."
placeholder: "It actually ..."
label: '📃 Provide any additional context for the Bug.'
description: 'Add any other context about the problem here.'
placeholder: 'It actually ...'
- type: checkboxes
id: no-duplicate-issues
attributes:
label: "👀 Have you spent some time to check if this bug has been raised before?"
label: '👀 Have you spent some time to check if this bug has been raised before?'
options:
- label: "I checked and didn't find a similar issue"
required: true
- type: checkboxes
id: read-code-of-conduct
attributes:
label: "🏢 Have you read the Contributing Guidelines?"
label: '🏢 Have you read the Contributing Guidelines?'
options:
- label: "I have read the [Contributing Guidelines](https://github.com/novuhq/novu/blob/main/CONTRIBUTING.md)"
- label: 'I have read the [Contributing Guidelines](https://github.com/novuhq/novu/blob/main/CONTRIBUTING.md)'
required: true
- type: dropdown
attributes:
label: Are you willing to submit PR?
description: This is absolutely not required, but we are happy to guide you in the contribution process. Find us in help-needed channel on [Discord](https://discord.gg/9wcGSf22PM)!
options:
- "Yes I am willing to submit a PR!"
- 'Yes I am willing to submit a PR!'
34 changes: 17 additions & 17 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: 🚀 Feature
description: "Submit a proposal for a new feature"
title: "🚀 Feature: "
description: 'Submit a proposal for a new feature'
title: '🚀 Feature: '
labels: [feature]
body:
- type: markdown
Expand All @@ -12,51 +12,51 @@ body:
validations:
required: true
attributes:
label: "🔖 Feature description"
description: "A clear and concise description of what the feature is."
placeholder: "You should add ..."
label: '🔖 Feature description'
description: 'A clear and concise description of what the feature is.'
placeholder: 'You should add ...'
- type: textarea
id: pitch
validations:
required: true
attributes:
label: "🎤 Why is this feature needed ?"
description: "Please explain why this feature should be implemented and how it would be used. Add examples, if applicable."
placeholder: "In my use-case, ..."
label: '🎤 Why is this feature needed ?'
description: 'Please explain why this feature should be implemented and how it would be used. Add examples, if applicable.'
placeholder: 'In my use-case, ...'
- type: textarea
id: solution
validations:
required: true
attributes:
label: "✌️ How do you aim to achieve this?"
description: "A clear and concise description of what you want to happen."
placeholder: "I want this feature to, ..."
label: '✌️ How do you aim to achieve this?'
description: 'A clear and concise description of what you want to happen.'
placeholder: 'I want this feature to, ...'
- type: textarea
id: alternative
validations:
required: false
attributes:
label: "🔄️ Additional Information"
label: '🔄️ Additional Information'
description: "A clear and concise description of any alternative solutions or additional solutions you've considered."
placeholder: "I tried, ..."
placeholder: 'I tried, ...'
- type: checkboxes
id: no-duplicate-issues
attributes:
label: "👀 Have you spent some time to check if this feature request has been raised before?"
label: '👀 Have you spent some time to check if this feature request has been raised before?'
options:
- label: "I checked and didn't find similar issue"
required: true
- type: checkboxes
id: read-code-of-conduct
attributes:
label: "🏢 Have you read the Code of Conduct?"
label: '🏢 Have you read the Code of Conduct?'
options:
- label: "I have read the [Contributing Guidelines](https://github.com/novuhq/novu/blob/main/CONTRIBUTING.md)"
- label: 'I have read the [Contributing Guidelines](https://github.com/novuhq/novu/blob/main/CONTRIBUTING.md)'
required: true
- type: dropdown
id: willing-to-submit-pr
attributes:
label: Are you willing to submit PR?
description: This is absolutely not required, but we are happy to guide you in the contribution process. Find us in help-needed channel on [Discord](https://discord.gg/9wcGSf22PM)!
options:
- "Yes I am willing to submit a PR!"
- 'Yes I am willing to submit a PR!'
4 changes: 4 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
### What changed? Why was the change needed?

<!-- Also include any relevant links, such as Linear tickets, Slack discussions, or design documents. -->

### Screenshots

<!-- If the changes are visual, include screenshots or screencasts. -->

<details>
<summary><strong>Expand for optional sections</strong></summary>

### Related enterprise PR

<!-- A link to a dependent pull request -->

### Special notes for your reviewer

<!-- Specific instructions or considerations you want to highlight for the reviewer. -->

</details>
12 changes: 6 additions & 6 deletions .github/actions/docker/build-api/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ runs:
aws-access-key-id: ${{ inputs.aws-access-key-id }}
aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
aws-region: eu-west-2

- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v2
Expand All @@ -67,7 +67,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/api
REPOSITORY: novu-dev/api
IMAGE_TAG: ${{ github.sha }}
DOCKER_BUILD_ARGUMENTS: >
--platform=linux/amd64 --provenance=false
Expand All @@ -81,7 +81,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/api
REPOSITORY: novu-dev/api
IMAGE_TAG: ${{ github.sha }}
run: |
echo "Built image"
Expand All @@ -97,7 +97,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/api
REPOSITORY: novu-dev/api
IMAGE_TAG: ${{ github.sha }}
run: |
docker tag $REGISTRY/$REPOSITORY:$IMAGE_TAG $REGISTRY/$REPOSITORY:${{ inputs.tag }}
Expand All @@ -107,7 +107,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/api
REPOSITORY: novu-dev/api
IMAGE_TAG: ${{ github.sha }}
run: |
docker push $REGISTRY/$REPOSITORY:$IMAGE_TAG
Expand All @@ -117,6 +117,6 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/api
REPOSITORY: novu-dev/api
run: |
docker push $REGISTRY/$REPOSITORY:${{ inputs.tag }}
12 changes: 6 additions & 6 deletions .github/actions/docker/build-worker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ runs:
aws-access-key-id: ${{ inputs.aws-access-key-id }}
aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
aws-region: eu-west-2

- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v2
Expand All @@ -67,7 +67,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/worker
REPOSITORY: novu-dev/worker
IMAGE_TAG: ${{ github.sha }}
DOCKER_BUILD_ARGUMENTS: >
--platform=linux/amd64 --provenance=false
Expand All @@ -81,7 +81,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/worker
REPOSITORY: novu-dev/worker
IMAGE_TAG: ${{ github.sha }}
run: |
echo "Built image"
Expand All @@ -97,7 +97,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/worker
REPOSITORY: novu-dev/worker
IMAGE_TAG: ${{ github.sha }}
run: |
docker tag $REGISTRY/$REPOSITORY:$IMAGE_TAG $REGISTRY/$REPOSITORY:${{ inputs.tag }}
Expand All @@ -107,7 +107,7 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/worker
REPOSITORY: novu-dev/worker
IMAGE_TAG: ${{ github.sha }}
run: |
docker push $REGISTRY/$REPOSITORY:$IMAGE_TAG
Expand All @@ -117,6 +117,6 @@ runs:
shell: bash
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REPOSITORY: novu-dev/worker
REPOSITORY: novu-dev/worker
run: |
docker push $REGISTRY/$REPOSITORY:${{ inputs.tag }}
8 changes: 4 additions & 4 deletions .github/actions/free-space/action.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: Extend Disk Space
description: This action removes some preinstalled tools in favor of opening space for our docker runs with QEMU
description: This action removes some preinstalled tools in favor of opening space for our docker runs with QEMU
runs:
using: composite
steps:
- name: Run script
run: |
set -eux

df -h
echo "::group::apt clean"
sudo apt clean
echo "::endgroup::"

echo "::group::/usr/local/*"
du -hsc /usr/local/*
echo "::endgroup::"
Expand Down Expand Up @@ -66,6 +66,6 @@ runs:
sudo rm -rf /opt/hostedtoolcache/CodeQL || :
# 1.4GB
sudo rm -rf /opt/hostedtoolcache/go || :

df -h
shell: bash
4 changes: 2 additions & 2 deletions .github/actions/run-api/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ runs:
shell: bash
env:
LAUNCH_DARKLY_SDK_KEY: ${{ inputs.launch_darkly_sdk_key }}
NODE_ENV: "test"
PORT: "1336"
NODE_ENV: 'test'
PORT: '1336'
run: cd apps/api && pnpm start:prod &

- name: Wait on API
Expand Down
10 changes: 5 additions & 5 deletions .github/actions/run-backend/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ runs:
env:
GITHUB_OAUTH_CLIENT_ID: ${{ inputs.cypress_github_oauth_client_id }}
GITHUB_OAUTH_CLIENT_SECRET: ${{ inputs.cypress_github_oauth_client_secret }}
NODE_ENV: "test"
PORT: "1336"
GITHUB_OAUTH_REDIRECT: "http://127.0.0.1:1336/v1/auth/github/callback"
NODE_ENV: 'test'
PORT: '1336'
GITHUB_OAUTH_REDIRECT: 'http://127.0.0.1:1336/v1/auth/github/callback'
LAUNCH_DARKLY_SDK_KEY: ${{ inputs.launch_darkly_sdk_key }}
CI_EE_TEST: ${{ inputs.ci_ee_test }}
run: cd apps/api && pnpm start:prod &

- name: Start Worker
shell: bash
env:
NODE_ENV: "test"
PORT: "1342"
NODE_ENV: 'test'
PORT: '1342'
LAUNCH_DARKLY_SDK_KEY: ${{ inputs.launch_darkly_sdk_key }}
CI_EE_TEST: ${{ inputs.ci_ee_test }}
run: cd apps/worker && pnpm start:prod &
Expand Down
Loading
Loading