feat(dashboard): delete step editor functionality #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChmaraX
commented
Nov 5, 2024
|
|
||
| const onDeleteStep = () => { | ||
| deleteStep(stepSlug); | ||
| navigate(buildRoute(ROUTES.EDIT_WORKFLOW, { environmentSlug: currentEnvironment?.slug ?? '', workflowSlug })); |
There was a problem hiding this comment.
Focus back to workflow after opened step is deleted, otherwise the sidebar with deleted step will remain opened with undefined data.
ChmaraX
commented
Nov 5, 2024
| stepName: string; | ||
| }; | ||
|
|
||
| export const DeleteStepModal = ({ open, onOpenChange, onConfirm, stepName }: DeleteStepModalProps) => { |
There was a problem hiding this comment.
I'll create a generic confirmation-modal in separate PR, since we use this same modal also for promotion and probably it will be used in other places.
ChmaraX
commented
Nov 5, 2024
Comment on lines
32
to
39
| const checkStepsDeleted = useCallback(() => { | ||
| const currentStepsLength = watchedData.steps?.length ?? 0; | ||
| const wasDeleted = previousStepsLength.current !== null && currentStepsLength < previousStepsLength.current; | ||
|
|
||
| previousStepsLength.current = currentStepsLength; | ||
|
|
||
| return wasDeleted; | ||
| }, [watchedData]); |
There was a problem hiding this comment.
Logic to determine if step was deleted in order to not use debounced save.
If we used debounced save for deletion, user could potentially refresh in the 500ms time window and the step wouldn't be deleted, although I'm not sure if its worth the additional logic.
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
delete_step_1.mp4