-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): new test-data endpoint to pass dynamic data #6871
Merged
djabarovgeorge
merged 14 commits into
next
from
nv-4600-refactor-new-workflowid-test-data-endpoint-to-pass-dynamic-data
Nov 7, 2024
Merged
refactor(api): new test-data endpoint to pass dynamic data #6871
djabarovgeorge
merged 14 commits into
next
from
nv-4600-refactor-new-workflowid-test-data-endpoint-to-pass-dynamic-data
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
changed the title
feat(api): complete email preview
refactor(api): new test-data endpoint to pass dynamic data
Nov 6, 2024
…4600-refactor-new-workflowid-test-data-endpoint-to-pass-dynamic-data # Conflicts: # apps/api/src/app/environments-v1/usecases/construct-framework-workflow/construct-framework-workflow.usecase.ts # apps/api/src/app/workflows-v2/generate-preview.e2e.ts # apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview-command.ts # apps/api/src/exception-filter.ts
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 13:11
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 13:11
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 13:11
— with
GitHub Actions
Inactive
❌ Deploy Preview for novu-stg-vite-dashboard-poc failed. Why did it fail? →
|
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
SokratisVidros
approved these changes
Nov 6, 2024
/** | ||
* Builds a JSON schema object where each variable becomes a string property. | ||
*/ | ||
export function buildStringSchema(variables: Record<string, unknown>): JSONSchema { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
export function buildStringSchema(variables: Record<string, unknown>): JSONSchema { | |
export function buildJSONSchema(variables: Record<string, unknown>): JSONSchema { |
The comment above it explains the rest ;)
…workflowid-test-data-endpoint-to-pass-dynamic-data
djabarovgeorge
had a problem deploying
to
Linting
November 6, 2024 15:19
— with
GitHub Actions
Error
djabarovgeorge
had a problem deploying
to
Linting
November 6, 2024 15:19
— with
GitHub Actions
Error
djabarovgeorge
had a problem deploying
to
Linting
November 6, 2024 15:19
— with
GitHub Actions
Error
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 15:21
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 15:21
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 15:21
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 15:34
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 15:34
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 6, 2024 15:34
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 7, 2024 09:34
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 7, 2024 09:34
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 7, 2024 09:34
— with
GitHub Actions
Inactive
…dpoint-to-pass-dynamic-data
djabarovgeorge
temporarily deployed
to
Linting
November 7, 2024 09:52
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 7, 2024 09:52
— with
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
November 7, 2024 09:52
— with
GitHub Actions
Inactive
djabarovgeorge
deleted the
nv-4600-refactor-new-workflowid-test-data-endpoint-to-pass-dynamic-data
branch
November 7, 2024 10:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer