Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): new test-data endpoint to pass dynamic data #6871

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Nov 6, 2024

@djabarovgeorge djabarovgeorge changed the title feat(api): complete email preview refactor(api): new test-data endpoint to pass dynamic data Nov 6, 2024
…4600-refactor-new-workflowid-test-data-endpoint-to-pass-dynamic-data

# Conflicts:
#	apps/api/src/app/environments-v1/usecases/construct-framework-workflow/construct-framework-workflow.usecase.ts
#	apps/api/src/app/workflows-v2/generate-preview.e2e.ts
#	apps/api/src/app/workflows-v2/usecases/generate-preview/generate-preview-command.ts
#	apps/api/src/exception-filter.ts
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for novu-stg-vite-dashboard-poc failed. Why did it fail? →

Name Link
🔨 Latest commit 7a0b4b0
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/672c8dc50bbc000008d7615c

Copy link

pkg-pr-new bot commented Nov 6, 2024

Open in Stackblitz

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6871

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6871

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6871

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6871

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6871

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6871

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6871

novu

pnpm add https://pkg.pr.new/novuhq/novu@6871

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6871

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6871

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6871

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6871

commit: 7a0b4b0

/**
* Builds a JSON schema object where each variable becomes a string property.
*/
export function buildStringSchema(variables: Record<string, unknown>): JSONSchema {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export function buildStringSchema(variables: Record<string, unknown>): JSONSchema {
export function buildJSONSchema(variables: Record<string, unknown>): JSONSchema {

The comment above it explains the rest ;)

Base automatically changed from complete-email-preview to next November 6, 2024 14:08
…workflowid-test-data-endpoint-to-pass-dynamic-data
@djabarovgeorge djabarovgeorge merged commit a2d7270 into next Nov 7, 2024
31 of 40 checks passed
@djabarovgeorge djabarovgeorge deleted the nv-4600-refactor-new-workflowid-test-data-endpoint-to-pass-dynamic-data branch November 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants