Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): Add support for specifying mock results #6878

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Nov 6, 2024

What changed? Why was the change needed?

  • Add support for specifying mock results during action=preview
    • Previously, mock results were only generated from the JSON schema for the step type. This change allows for specification of a state object to flexibly and accurately display preview content that depends on other step results

Screenshots

N/A, see new tests in PR

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

linear bot commented Nov 6, 2024

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for novu-stg-vite-dashboard-poc failed. Why did it fail? →

Name Link
🔨 Latest commit e34e08b
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/672bf8f9c7b3f70008670df5

Copy link

pkg-pr-new bot commented Nov 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6878

commit: e34e08b

@rifont rifont merged commit 0238e2b into next Nov 7, 2024
33 of 42 checks passed
@rifont rifont deleted the nv-4603-utilize-state-object-values-for-preview-action-in-framework branch November 7, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants