fix(dal): Reduce default Mongo connections #6901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Failure
SokratisVidros
changed the title
SokratisVidros
force-pushed
the
reduce_mongo_connections
branch
from
ff183a2
to
9531ea8
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
libs/dal/src/dal.service.ts
Outdated
| @@ -1,16 +1,16 @@ | |||
| import mongoose, { Connection, ConnectOptions } from 'mongoose'; | |||
|
|
|||
| export const baseConfig: ConnectOptions = { | |||
| autoIndex: process.env.MONGO_AUTO_CREATE_INDEXES === 'true', | |||
There was a problem hiding this comment.
This is a breaking change for the self-hosted users do we want to use AUTO_CREATE_INDEXES as well for couple of version and then deprecated it?
Suggested change
| autoIndex: process.env.MONGO_AUTO_CREATE_INDEXES === 'true', | |
| autoIndex: process.env.AUTO_CREATE_INDEXES === 'true' || process.env.MONGO_AUTO_CREATE_INDEXES === 'true', |
SokratisVidros
force-pushed
the
reduce_mongo_connections
branch
from
9531ea8
to
27109e5
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
rifont
reviewed
Nov 11, 2024
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
rifont
reviewed
Nov 11, 2024
rifont
reviewed
Nov 11, 2024
rifont
reviewed
Nov 11, 2024
SokratisVidros
force-pushed
the
reduce_mongo_connections
branch
from
c7c3a5a
to
dd62dac
Compare
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Error
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Error
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Error
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Error
SokratisVidros
had a problem deploying
to
Linting
GitHub Actions
Error
SokratisVidros
force-pushed
the
reduce_mongo_connections
branch
from
3d52d91
to
331a08a
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer