Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api, worker): Instrument workflow v2 controller and bridge use-cases #7150

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

rifont
Copy link
Contributor

@rifont rifont commented Nov 27, 2024

What changed? Why was the change needed?

  • Add instrumentation for all workflow v2 controller use-cases
    • largely focusses on async methods which are typically the least performant
  • Add instrumentation for bridge-request and bridge-job use-cases

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 3c4fe9a
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67478e53ea5aa5000867f8ce
😎 Deploy Preview https://deploy-preview-7150.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@tatarco tatarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎻

@rifont rifont merged commit 3fe3c28 into next Nov 27, 2024
30 checks passed
@rifont rifont deleted the instrument-workflow-v2-controller branch November 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants