feat(api): add exception log #7225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
approved these changes
Dec 5, 2024
SokratisVidros
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
It seems we rely heavily on the Pino logger's
request erroredevent to give us details about errors. However, the error object is quite limited and only provides minimal information.{ error : {class, message, stack} }I tried passing extra data, but it wasn't provided. Even pinoLogger.assign didn’t include the additional workflow ID parameter.
Adding another log in the exception filter, like we do for 5XX errors, allows us to include more parameters.
We could add this log to provide a structured object.
The next step could be disabling autoLogging in the Pino logger since
request erroredis already handled in the ExceptionFilter.If
request completedis needed, we can add it to the Next.js Interceptor.Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer