Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrossSearch api tests #254

Merged
merged 8 commits into from
Sep 25, 2024
Merged

CrossSearch api tests #254

merged 8 commits into from
Sep 25, 2024

Conversation

Deeroil
Copy link
Collaborator

@Deeroil Deeroil commented Sep 24, 2024

  • still has ts-errors that haven't been cleared
    • are we going to ignore them or look into how they should/could be handled?
  • waiting for beforeEach changes for test database (otherwise the tests won't always produce same result)

Not yet rebased to main AND PLEASE DON'T! Main might be broken right now :D

@EeroAnt
Copy link
Collaborator

EeroAnt commented Sep 25, 2024

Added small error margin for the length of returned list.
Removed 'before each await login' as these tests don't need login
Edited tests to check if the returned list contains wanted things rather than checking the first element of said list

@EeroAnt
Copy link
Collaborator

EeroAnt commented Sep 25, 2024

Increased error margin..

@EeroAnt
Copy link
Collaborator

EeroAnt commented Sep 25, 2024

#179

@EeroAnt EeroAnt marked this pull request as ready for review September 25, 2024 14:46
iritmaximus
iritmaximus approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@iritmaximus iritmaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritmaximus iritmaximus merged commit 2326f50 into main Sep 25, 2024
3 checks passed
@iritmaximus iritmaximus deleted the cross-search-test branch September 25, 2024 14:52
@iritmaximus iritmaximus mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritmaximus iritmaximus iritmaximus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deeroil @EeroAnt @iritmaximus