feat: Add JSON output option to battery and device list #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses #26 (my own issue) in order to serve as a base for deciding on an approach |
|
I think it would be better to just do a global flag instead of adding it to each command: |
|
I honestly just don't have the time to look at this at the moment, so unfortunately I'm closing this. If anyone wants to take it over the finish line, feel free, but I don't want to leave this open forever when I'm not able to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass investigating how to add JSON output to some (or all?) of the commands.
As I am not an experienced C programmer, any feedback is welcome, however for reference my plan was to simply use printf and manually handle the output in order to avoid having to bring in any third party dependencies for json serialization.
As there isn't a huge amount of output, I believe this is sustainable for the time being, but easily reworked if need be.