Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use Application.temporaryCachePath in tests if possible #111

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

nowsprinting
Copy link
Owner

@nowsprinting nowsprinting commented Nov 24, 2024

Changes

  • Fix to use Application.temporaryCachePath in tests if possible
  • Add open Application.temporaryCachePath menu item

@nowsprinting nowsprinting requested a review from Copilot November 24, 2024 17:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • Editor/OpenTemporaryCachePathMenu.cs.meta: Language not supported
Comments skipped due to low confidence (1)

Editor/OpenTemporaryCachePathMenu.cs:10

  • [nitpick] The term 'Finder' is specific to macOS. Consider changing it to 'file explorer' to make it more platform-agnostic.
/// Open temporary cache directory in the Finder.
@github-actions github-actions bot added the chore label Nov 24, 2024
Copy link

Code Metrics Report

master (40a990b) #111 (203f654) +/-
Coverage 78.4% 78.1% -0.3%
Code to Test Ratio 1:0.7 1:0.7 -0.1
Test Execution Time 4m34s 4m45s +11s
Details
  |                     | master (40a990b) | #111 (203f654) |  +/-  |
  |---------------------|------------------|----------------|-------|
- | Coverage            |            78.4% |          78.1% | -0.3% |
  |   Files             |               34 |             35 |    +1 |
  |   Lines             |             1033 |           1036 |    +3 |
  |   Covered           |              810 |            810 |     0 |
- | Code to Test Ratio  |            1:0.7 |          1:0.7 |  -0.1 |
  |   Code              |             1815 |           1828 |   +13 |
+ |   Test              |             1419 |           1421 |    +2 |
- | Test Execution Time |            4m34s |          4m45s |  +11s |

Code coverage of files in pull request scope (0.0% → 0.0%)

Files Coverage +/-
Editor/OpenPersistentDataPathMenu.cs 0.0% 0.0%
Editor/OpenTemporaryCachePathMenu.cs 0.0% 0.0%

Reported by octocov

@nowsprinting nowsprinting changed the title Add open Application.temporaryCachePath menu item Fix to use Application.temporaryCachePath in tests if possible Nov 24, 2024
@nowsprinting nowsprinting merged commit 3495ef9 into master Nov 24, 2024
15 checks passed
@nowsprinting nowsprinting deleted the chore/temporary_cache_path branch November 24, 2024 17:55
@nowsprinting nowsprinting mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant