-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kms_master_key_id to alarm baseline and config-baseline module #216
Conversation
fwiw, kms encryption support for config was just merged yesterday. should be available in the release this coming thursday! |
@willfarrell Thank you, this looks a good intermediary approach until the multi-region key is supported in the upstream. |
Sounds good |
@nozaq Could you create the next version 0.29.0 with those changes? |
@pperzyna Just published v0.29.0 👍🏼 |
@nozaq This was a breaking change, right? Just want to ensure that it's expected now always set |
@KnupMan Thanks for the heads up. It didn't break anything in my environment during my test, but let me check again. |
@KnupMan Ah, you're right. |
The fix has been merged and published as v0.29.1. |
Building onto of the great work by @mknapcok in PR #182. As mentioned in the other PR, I think this is as far as we can go till multi-region kms is supported.
Not sure where you'd like the example on how to use this addition
Closes #163