Fix assertion with igncr when CR on input #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered a problem with function
do_map
. When I run picocom with--imap igncr
it fails with assertion with CR character on input which it should just ignore.
do_map: Assertion 'n > 0 && n <= M_MAXMAP' failed.
After bisecting the code, it was introduced by commit 50b8e69
It seems that n is also valid for value 0, si this fix allow this value