Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix For issue #106 #163

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix For issue #106 #163

wants to merge 6 commits into from

Conversation

sparkybg
Copy link

@sparkybg sparkybg commented Sep 22, 2020

This should be full fix for test also. Both AlterColumnOperation, CreateTableOperation and AddColumnOpreation are consistent now, along with their tests.

Old pull request is closed by mistake, So I've created this one. Sorry.

sparkybg and others added 6 commits September 18, 2020 13:02
Co-authored-by: Shay Rojansky <roji@roji.org>
Added tests for AddColumnOperation and AlterColumnOperation for non-nullable columns without explicitly specified default value.
@sparkybg
Copy link
Author

I don't know what happened but this pull request modifications are again not present and issue #106 is still present in the latest release.

What shoud I do to commit it again?

@sparkybg sparkybg mentioned this pull request Aug 12, 2021
@roji
Copy link
Member

roji commented Aug 12, 2021

@sparkybg I'm not sure I understand - are you not managing to push your local modifications to this PR on github?

@sparkybg
Copy link
Author

sparkybg commented Aug 12, 2021

I dont understand either - the modifications in this pull request are visible in the commits, for example here:
3bcdb98

And here:
55bef39

But they are not present in the current source code here:
https://github.com/npgsql/EntityFramework6.Npgsql/blob/main/EF6.PG/NpgsqlMigrationSqlGenerator.cs

I don't know what happened. I deleted my local repository maybe a month ago, but they shoud have been pushed already long before this - the commits are nearly 1 year old.

Nothing is visible on the history also:
https://github.com/npgsql/EntityFramework6.Npgsql/commits/main/EF6.PG/NpgsqlMigrationSqlGenerator.cs

@roji
Copy link
Member

roji commented Aug 12, 2021

@sparkybg this pull request was never merged, it's still open - this is why its changes aren't appearing in the main branch... Are you waiting for this to be reviewed and merged?

@sparkybg
Copy link
Author

Well, should I do something in order for it to be merged? This is mandatory for code-first migrations when non-nullable columns are added to a table which already has data in it.

@roji
Copy link
Member

roji commented Aug 12, 2021

This would need to get reviewed and merged, given that this project is mostly archived there isn't much happening. @Emill are you interested in taking a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants