Reload types should close the newly opened connection. (#3561)

marcusber · roji · commit 5014ee69d9aa · 2025-06-30T10:48:39.000+02:00
Fixes #3560 (cherry picked from commit fb96538)
diff --git a/src/EFCore.PG/Storage/Internal/NpgsqlDatabaseCreator.cs b/src/EFCore.PG/Storage/Internal/NpgsqlDatabaseCreator.cs
@@ -354,7 +354,7 @@ public override void CreateTables()
             {
                 npgsqlConnection.ReloadTypes();
             }
-            catch
+            finally
             {
                 npgsqlConnection.Close();
             }
@@ -396,7 +396,7 @@ await Dependencies.MigrationCommandExecutor.ExecuteNonQueryAsync(commands, conne
             {
                 await npgsqlConnection.ReloadTypesAsync(cancellationToken).ConfigureAwait(false);
             }
-            catch
+            finally
             {
                 await npgsqlConnection.CloseAsync().ConfigureAwait(false);
             }

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,7 @@ public override void CreateTables()`
`354`	`354`	`{`
`355`	`355`	`npgsqlConnection.ReloadTypes();`
`356`	`356`	`}`
`357`		`- catch`
	`357`	`+ finally`
`358`	`358`	`{`
`359`	`359`	`npgsqlConnection.Close();`
`360`	`360`	`}`
`@@ -396,7 +396,7 @@ await Dependencies.MigrationCommandExecutor.ExecuteNonQueryAsync(commands, conne`
`396`	`396`	`{`
`397`	`397`	`await npgsqlConnection.ReloadTypesAsync(cancellationToken).ConfigureAwait(false);`
`398`	`398`	`}`
`399`		`- catch`
	`399`	`+ finally`
`400`	`400`	`{`
`401`	`401`	`await npgsqlConnection.CloseAsync().ConfigureAwait(false);`
`402`	`402`	`}`