Skip to content

Reload types should close the newly opened connection. #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

Reload types should close the newly opened connection. #3561

merged 2 commits into from
Jun 30, 2025

Conversation

@marcusber
Copy link
Contributor

@marcusber marcusber commented Jun 30, 2025 •
edited by roji
Loading

Always close connection after types was reloaded.

Fixes #3560

roji
roji requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch! There's the same problem just below in the async version, can you please fix that too?

@marcusber
Copy link
Contributor Author

marcusber commented Jun 30, 2025

Thanks, good catch! There's the same problem just below in the async version, can you please fix that too?

Did you end up on the last commit? Both are changed in this PR. Can't see what you are referring to.

roji
roji approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I see the second fix now, my bad.

@roji roji merged commit fb96538 into npgsql:main Jun 30, 2025
15 checks passed
roji pushed a commit that referenced this pull request Jun 30, 2025
@marcusber @roji
Reload types should close the newly opened connection. (#3561)
5014ee6 
Fixes #3560

(cherry picked from commit fb96538)
@roji
Copy link
Member

roji commented Jun 30, 2025

Backported to 9.0.5 via 5014ee6

@marcusber marcusber mentioned this pull request Jun 30, 2025
Closed
This was referenced Nov 24, 2025
Merged
Merged
Merged
Closed
Open
Open
Merged
Merged
Open
Closed
Open
Closed
Open
Closed
Closed
Merged
Closed
This was referenced Dec 1, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roji roji roji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Connection not closed after migration when using NodaTime

2 participants

@marcusber @roji