Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mapping should be cloned with RelationalTypeMappingInfo before being returned #1476

Closed
roji opened this issue Aug 28, 2020 · 1 comment · Fixed by #1477
Closed

Type mapping should be cloned with RelationalTypeMappingInfo before being returned #1476

roji opened this issue Aug 28, 2020 · 1 comment · Fixed by #1477
Assignees
@roji
Labels
bug Something isn't working
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Aug 28, 2020

NpgsqlTypeMappingSource isn't cloning the resulting type mapping with the RelationalTypeMappingInfo before returning it, this could cause some wrong info to be populated in the type mapping. This caused tests to fail when syncing with EF 5.0.0-rc1, but curiously hasn't been raised as an issue yet in previous versions.
@roji roji added the bug Something isn't working label Aug 28, 2020
@roji roji added this to the 3.1.7 milestone Aug 28, 2020
@roji roji self-assigned this Aug 28, 2020
roji added a commit to roji/efcore.pg that referenced this issue Aug 28, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
ebd6633 
Fixes npgsql#1476
roji added a commit to roji/efcore.pg that referenced this issue Aug 28, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
102dacf 
Fixes npgsql#1476
roji added a commit to roji/efcore.pg that referenced this issue Aug 28, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
e10d965 
Fixes npgsql#1476
roji added a commit to roji/efcore.pg that referenced this issue Aug 28, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
3ab031c 
Fixes npgsql#1476
@roji
Copy link
Member Author

roji commented Aug 29, 2020

The fix isn't totally trivial and the bug hasn't manifested itself in 3.1, so am going to fix only for 5.0 for now.

@roji roji modified the milestones: 3.1.7, 5.0.0 Aug 29, 2020
roji added a commit to roji/efcore.pg that referenced this issue Aug 29, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
e611e93 
Fixes npgsql#1476
@roji roji linked a pull request Aug 29, 2020 that will close this issue
Sync to 5.0.0-rc.1.20426.3 #1477
Merged
roji added a commit to roji/efcore.pg that referenced this issue Aug 29, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
dc883c8 
Fixes npgsql#1476
roji added a commit that referenced this issue Aug 31, 2020
@roji
Properly clone type mapping with RelationalTypeMappinfInfo
51d7851 
Fixes #1476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
bug Something isn't working
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Sync to 5.0.0-rc.1.20426.3 roji/efcore.pg
1 participant
@roji