Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hstore columns to be represented as ImmutableDictionary<string, string> #1491

Closed
roji opened this issue Sep 8, 2020 · 3 comments · Fixed by #1492
Closed

Allow hstore columns to be represented as ImmutableDictionary<string, string> #1491

roji opened this issue Sep 8, 2020 · 3 comments · Fixed by #1492
Assignees
@Quogu @roji
Labels
enhancement New feature or request
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Sep 8, 2020

Most of the work here was done by @Quogu in #1184.

This allows using the .NET Immutable type, but also does much faster change tracking since a reference comparison is enough to know whether the dictionary contents have changed.
@roji roji added the enhancement New feature or request label Sep 8, 2020
@roji roji added this to the 5.0.0 milestone Sep 8, 2020
@roji roji self-assigned this Sep 8, 2020
@roji roji linked a pull request Sep 8, 2020 that will close this issue
Allow hstore columns to be represented as ImmutableDictionary<string, string> #1184
Closed
@roji roji changed the title Allow hstore columns to be represented as ImmutableDictionary<string, string> Allow hstore columns to be represented as ImmutableDictionary<string, string> Sep 8, 2020
@roji
Copy link
Member Author

roji commented Sep 8, 2020 •
edited
Loading

@QuoGo @Quogu can you please post a comment here so I can assign the issue to you? This way you get more visible credit for working on it.

roji pushed a commit that referenced this issue Sep 8, 2020
@Quogu @roji
Map hstore to ImmutableDictionary
2b3be6f 
Closes #1491
@roji roji mentioned this issue Sep 8, 2020
Merged
@Quogu
Copy link
Contributor

Quogu commented Sep 8, 2020

@roji my username is a tricky one to spell, but I can definitely leave a comment. :) Thanks!

@roji
Copy link
Member Author

roji commented Sep 8, 2020

Oops sorry :) The important this is that we got there... You can check out #1492 which replaces your PR and is ready to merge, except for needing to depend on a newer Npgsql.

roji pushed a commit to roji/efcore.pg that referenced this issue Sep 13, 2020
@Quogu @roji
Map hstore to ImmutableDictionary
56e7007 
Closes npgsql#1491
roji pushed a commit to roji/efcore.pg that referenced this issue Oct 3, 2020
@Quogu @roji
Map hstore to ImmutableDictionary
03814c1 
Closes npgsql#1491
roji pushed a commit to roji/efcore.pg that referenced this issue Oct 3, 2020
@Quogu @roji
Map hstore to ImmutableDictionary
ca162bf 
Closes npgsql#1491
roji pushed a commit to roji/efcore.pg that referenced this issue Oct 3, 2020
@Quogu @roji
Map hstore to ImmutableDictionary
41b3664 
Closes npgsql#1491
@roji roji closed this as completed in #1492 Oct 3, 2020
roji added a commit that referenced this issue Oct 3, 2020
@roji @Quogu
Map hstore to ImmutableDictionary (#1492)
498710d 
Closes #1491

Co-authored-by: Elliot Quogu Prior <1709938+Quogu@users.noreply.github.com>
@roji roji mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Quogu Quogu

@roji roji

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0.0
2 participants
@Quogu @roji