Non-nullable bool domain is scaffolded to nullable property

[kobruleht]

Steps to reproduce:

1. Create non-nullable bool in postgres:

CREATE DOMAIN ebool AS bool DEFAULT false NOT NULL;

2. Create column with this type

CREATE TABLE test ( testbool ebool );

3. Generate classes from database using

dotnet ef dbcontext scaffold "Host=my_host;Database=my_db;Username=my_user;Password=my_pw" Npgsql.EntityFrameworkCore.PostgreSQL

Observed:

Property is bool? type:

public partial class Test
{
    public bool? Testbool { get; set; }

Expected:
Property should be bool type:

    public bool Testbool { get; set; }

[kobruleht]

It looks like this commit does not add support for not-nullable boolean. It adds only not-nullable string and integer type support.

[roji]

@kobruleht what makes you say that? The tests check int/string, but the change itself is valid for any PostgreSQL domain, isn't it?