Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IS NULL parentheses hack (again) #2105

Closed
roji opened this issue Nov 17, 2021 · 0 comments · Fixed by #2534
Closed

Remove IS NULL parentheses hack (again) #2105

roji opened this issue Nov 17, 2021 · 0 comments · Fixed by #2534
Assignees
@roji
Labels
enhancement New feature or request
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented Nov 17, 2021

We currently have a hack (#2104) which adds parentheses around IS NULL/IS NOT NULL. This is because of dotnet/efcore#26652; once that gets fixed, we can remove the hack on our side.
@roji roji added the enhancement New feature or request label Nov 17, 2021
@roji roji added this to the 7.0.0 milestone Nov 17, 2021
@roji roji self-assigned this Nov 17, 2021
This was referenced Nov 17, 2021
Merged
Closed
roji added a commit to roji/efcore.pg that referenced this issue Oct 15, 2022
@roji
Remove IS NULL parentheses hack
0249463 
(leaving the one on the EF side)

Closes npgsql#2105
@roji roji mentioned this issue Oct 15, 2022
Merged
roji added a commit to roji/efcore.pg that referenced this issue Oct 15, 2022
@roji
Remove IS NULL parentheses hack
81d5ee1 
(leaving the one on the EF side)

Closes npgsql#2105
roji added a commit that referenced this issue Oct 15, 2022
@roji
Remove IS NULL parentheses hack (#2534)
95aa5c4 
(leaving the one on the EF side)

Closes #2105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
enhancement New feature or request
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Remove IS NULL parentheses hack roji/efcore.pg
1 participant
@roji