Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to EF-internal TpcTablesExpression #2387

Closed
roji opened this issue May 29, 2022 · 3 comments · Fixed by dotnet/efcore#28142
Closed

Remove reference to EF-internal TpcTablesExpression #2387

roji opened this issue May 29, 2022 · 3 comments · Fixed by dotnet/efcore#28142
Assignees
@roji
Labels
cleanup
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented May 29, 2022

In #2366, I added NpgsqlSetOperationTypeResolutionCompensatingExpressionVisitor, which adds an explicit convert node on the leftmost set operation operand, to work around problematic PG type inference behavior.

At the moment, this visitor needs to visit the EF-internal TpcTablesExpression. @smitpatel will be looking at changes on the EF side to obviate this. This is non-critical.
@roji roji added this to the 7.0.0 milestone May 29, 2022
@roji roji self-assigned this May 29, 2022
@smitpatel
Copy link

I am already working on this. Many edge cases but it will be done in 7.0

@roji
Copy link
Member Author

roji commented May 29, 2022

Thanks @smitpatel, no rush as I said, I have no problem even shipping like this.

smitpatel added a commit to dotnet/efcore that referenced this issue Jun 1, 2022
@smitpatel
Query: Remove TpcTablesExpression once pruning is done
7a1c73a 
- Apply pruning on subqueries in set operation when not distinct
- Avoid table aliases which would be pruned in TPC later
- Avoid push down when left-joining with TPC select expression

Resolves npgsql/efcore.pg#2387
Resolves #28009
smitpatel added a commit to dotnet/efcore that referenced this issue Jun 1, 2022
@smitpatel
Query: Remove TpcTablesExpression once pruning is done
8121b4e 
- Apply pruning on subqueries in set operation when not distinct
- Avoid table aliases which would be pruned in TPC later
- Avoid push down when left-joining with TPC select expression

Resolves npgsql/efcore.pg#2387
Resolves #28009
@smitpatel smitpatel mentioned this issue Jun 1, 2022
Merged
smitpatel added a commit to dotnet/efcore that referenced this issue Jun 1, 2022
@smitpatel
Query: Remove TpcTablesExpression once pruning is done
ee30e79 
- Apply pruning on subqueries in set operation when not distinct
- Avoid table aliases which would be pruned in TPC later
- Avoid push down when left-joining with TPC select expression

Resolves npgsql/efcore.pg#2387
Resolves #28009
ghost pushed a commit to dotnet/efcore that referenced this issue Jun 2, 2022
@smitpatel
Query: Remove TpcTablesExpression once pruning is done (#28142)
f43f454 
- Apply pruning on subqueries in set operation when not distinct
- Avoid table aliases which would be pruned in TPC later
- Avoid push down when left-joining with TPC select expression

Resolves npgsql/efcore.pg#2387
Resolves #28009
@roji roji removed the blocked label Jun 2, 2022
@roji
Copy link
Member Author

roji commented Oct 15, 2022

This was done.

@roji roji closed this as completed Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
cleanup
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Query: Remove TpcTablesExpression once pruning is done dotnet/efcore
2 participants
@smitpatel @roji