Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support array value conversion with non-array/List CLR type #2759

Closed
roji opened this issue May 19, 2023 · 2 comments · Fixed by #2922
Closed

Support array value conversion with non-array/List CLR type #2759

roji opened this issue May 19, 2023 · 2 comments · Fixed by #2922
Assignees
@roji
Labels
enhancement New feature or request
Milestone
8.0.0

Comments

@roji
Copy link
Member

roji commented May 19, 2023 •
edited
Loading

Up to version 8.0, the provider supports mapping only .NET arrays and List<T> to PG array; version 8.0 extended this to allow any IEnumerable (#2726). However, we still only support (element) value conversion for array/List.

Note: for now I restricted support back to IList, but the converter still only supports array and List specifically.
@roji roji added the enhancement New feature or request label May 19, 2023
@roji roji added this to the 8.0.0 milestone May 19, 2023
@roji roji self-assigned this May 19, 2023
@r-work
Copy link

r-work commented May 22, 2023

I just ran into this issue in 8.0.0-preview.4.
For now converting collection (IEnumerable<T>) to .ToArray() seems to be working.

@roji
Copy link
Member Author

roji commented May 22, 2023

Yeah, we're discussing/working on this at the moment. I'm not sure we'll be able to support anything beyond IList (at least not in an efficient way), but stay tuned.

roji added a commit to roji/efcore.pg that referenced this issue Oct 30, 2023
@roji
Big array mapping/converter redo
a65cba9 
Add support for concrete/non-concrete collection type, supporting interface collections

Closes npgsql#2759
roji added a commit to roji/efcore.pg that referenced this issue Oct 30, 2023
@roji
Big array mapping/converter redo
022a92d 
Add support for concrete/non-concrete collection type, supporting interface collections

Closes npgsql#2759
roji added a commit to roji/efcore.pg that referenced this issue Nov 6, 2023
@roji
Support for JSON owned entities
9328c6f 
Closes npgsql#2759
@roji roji mentioned this issue Nov 6, 2023
Merged
@roji roji closed this as completed in #2922 Nov 6, 2023
roji added a commit that referenced this issue Nov 6, 2023
@roji
Support for JSON owned entities (#2922)
4a7ef97 
Closes #2548
Closes #2759
@roji roji mentioned this issue Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
enhancement New feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Support for JSON owned entities roji/efcore.pg
2 participants
@roji @r-work