Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with new EF Core comments support #892

Closed
roji opened this issue May 22, 2019 · 1 comment · Fixed by #992
Closed

Align with new EF Core comments support #892

roji opened this issue May 22, 2019 · 1 comment · Fixed by #992
Assignees
@roji
Labels
cleanup
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented May 22, 2019

If/when dotnet/efcore#15037 is done
@roji roji added this to the 3.0.0 milestone May 22, 2019
@roji roji removed the blocked label Jul 25, 2019
@roji roji self-assigned this Jul 25, 2019
@roji roji mentioned this issue Jul 26, 2019
Merged
roji added a commit to roji/efcore.pg that referenced this issue Jul 28, 2019
@roji
New EF Core comment support
0117ee5 
Closes npgsql#892
@roji roji mentioned this issue Jul 28, 2019
Closed
roji added a commit to roji/efcore.pg that referenced this issue Jul 28, 2019
@roji
New EF Core comment support
558df46 
Closes npgsql#892
@roji
Copy link
Member Author

roji commented Aug 11, 2019

Final piece of work has been merged upstream (dotnet/efcore#16981), wait until we sync with preview9 to see it.

roji added a commit that referenced this issue Aug 22, 2019
@roji
New EF Core comment support
bebab8d 
Closes #892
@roji roji mentioned this issue Aug 22, 2019
Merged
roji added a commit that referenced this issue Aug 22, 2019
@roji
New EF Core comment support
8c85d14 
Closes #892
roji added a commit that referenced this issue Aug 22, 2019
@roji
New EF Core comment support
1130285 
Closes #892
@roji roji closed this as completed in #992 Aug 22, 2019
roji added a commit that referenced this issue Aug 22, 2019
@roji
New EF Core comment support
5a661b2 
Closes #892
@roji roji added cleanup and removed refactor labels May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
cleanup
Projects
None yet
Milestone
3.0.0
1 participant
@roji