Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PERFORM within PL/pgSQL block to discard result #1092

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Use PERFORM within PL/pgSQL block to discard result #1092

merged 1 commit into from
Oct 28, 2019

Conversation

austindrenski
Copy link
Contributor

Fixes: #1089

@austindrenski austindrenski added the bug Something isn't working label Oct 24, 2019
@austindrenski austindrenski self-assigned this Oct 24, 2019
@austindrenski austindrenski merged commit f9e62e5 into npgsql:dev Oct 28, 2019
@austindrenski austindrenski deleted the patch-issue-1089 branch October 28, 2019 05:53
austindrenski added a commit that referenced this pull request Oct 28, 2019
@austindrenski
Use PERFORM within PL/pgSQL block to discard result (#1092)
a4e719b 
(cherry picked from commit f9e62e5)
@austindrenski
Copy link
Contributor Author

Backported to 3.0.2 via a4e719b.

@roji
Copy link
Member

roji commented Oct 28, 2019

Thanks @austindrenski!

Can you please confirm that you've done an actual test of this migration scenario, to make sure the SQL work correctly? No need for an automated test, just an actual test once?

roji added a commit that referenced this pull request Dec 9, 2019
@roji
Revert "Use PERFORM within PL/pgSQL block to discard result (#1092)"
f6360d9 
This reverts commit f9e62e5.

Fixes #1154
@roji roji mentioned this pull request Dec 9, 2019
Closed
roji added a commit that referenced this pull request Dec 9, 2019
@roji
Revert "Use PERFORM within PL/pgSQL block to discard result (#1092)"
6786e9c 
This reverts commit f9e62e5.

Fixes #1154
roji added a commit that referenced this pull request Dec 9, 2019
@roji
Revert "Use PERFORM within PL/pgSQL block to discard result (#1092)"
4c07e73 
This reverts commit f9e62e5.

Fixes #1154

(cherry picked from commit 6786e9c)
roji added a commit that referenced this pull request Feb 3, 2020
@roji
Revert "Use PERFORM within PL/pgSQL block to discard result (#1092)"
72498a6 
This reverts commit f9e62e5.

Fixes #1154

(cherry picked from commit 6786e9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohDeadfall YohDeadfall YohDeadfall approved these changes

@roji roji roji approved these changes

Assignees

@austindrenski austindrenski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select used instead of Perform in migration causes issues when executing the migration SQL via PSQL
3 participants
@austindrenski @roji @YohDeadfall