Skip to content

Don't use same table in join when it is also primary target table #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Don't use same table in join when it is also primary target table #3263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.PG/Query/Internal/NpgsqlQuerySqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ protected override Expression VisitUpdate(UpdateExpression updateExpression)
var table = selectExpression.Tables[i];
var joinExpression = table as JoinExpressionBase;

if (ReferenceEquals(updateExpression.Table, joinExpression?.Table ?? table))
if (updateExpression.Table.Alias == (joinExpression?.Table.Alias ?? table.Alias))
{
LiftPredicate(table);
continue;
Expand Down
11 changes: 8 additions & 3 deletions test/EFCore.PG.FunctionalTests/BulkUpdates/NonSharedModelBulkUpdatesNpgsqlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,17 @@ DELETE FROM "Owner" AS o
""");
}

// TODO: #3253
public override async Task Replace_ColumnExpression_in_column_setter(bool async)
{
var exception = await Assert.ThrowsAsync<PostgresException>(() => base.Replace_ColumnExpression_in_column_setter(async));
await base.Replace_ColumnExpression_in_column_setter(async);

Assert.Equal("42712", exception.SqlState);
AssertSql(
"""
UPDATE "OwnedCollection" AS o0
SET "Value" = 'SomeValue'
FROM "Owner" AS o
WHERE o."Id" = o0."OwnerId"
""");
}

public override async Task Delete_aggregate_root_when_table_sharing_with_non_owned_throws(bool async)
Expand Down