Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore virtual modifier #3382

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Restore virtual modifier #3382

merged 1 commit into from
Nov 20, 2024

Conversation

virzak
Copy link
Contributor

@virzak virzak commented Nov 20, 2024

Resolves #3381

roji
roji approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @virzak - I'll backport this for 9.0.2 (though it'll take a bit of time before I release that, as we wait for other issues to come in...).

@roji roji enabled auto-merge (squash) November 20, 2024 17:06
@roji roji merged commit c6fb5e2 into npgsql:main Nov 20, 2024
15 checks passed
roji pushed a commit that referenced this pull request Nov 20, 2024
@virzak @roji
Restore virtual modifier (#3382)
17e2fc8 
(cherry picked from commit c6fb5e2)
@roji
Copy link
Member

roji commented Nov 20, 2024

Backported to 9.0.2 via 17e2fc8

@virzak
Copy link
Contributor Author

virzak commented Nov 20, 2024

Thanks, @roji, looking forward to the release

WhatzGames pushed a commit to WhatzGames/efcore.pg that referenced this pull request Dec 18, 2024
@virzak @WhatzGames
Restore virtual modifier (npgsql#3382)
b32ff5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make NpgsqlParameterBasedSqlProcessorFactory.Create virtual again
2 participants
@virzak @roji