Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NullIf Translation for Ternary expressions #3403

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Add NullIf Translation for Ternary expressions #3403

merged 4 commits into from
Dec 11, 2024

Conversation

WhatzGames
Copy link
Contributor

closes #596

roji
roji approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FYI I've pushed a commit to this PR which simplifies the implementation and fixes some stuff.

@roji roji enabled auto-merge (squash) December 11, 2024 22:20
@roji roji merged commit 2397dd8 into npgsql:main Dec 11, 2024
17 checks passed
@roji roji mentioned this pull request Dec 13, 2024
Open
WhatzGames added a commit to WhatzGames/efcore.pg that referenced this pull request Dec 18, 2024
@WhatzGames @roji
Add NullIf Translation for Ternary expressions (npgsql#3403)
1f18573 
Closes npgsql#596

Co-authored-by: Shay Rojansky <roji@roji.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate NULLIF
2 participants
@WhatzGames @roji