Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Feb 14, 2025

Fixes #3460

@roji roji requested a review from Copilot February 14, 2025 22:21
@roji roji enabled auto-merge (squash) February 14, 2025 22:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/EFCore.PG/ValueGeneration/Internal/NpgsqlValueGeneratorSelector.cs:109

  • Ensure that the new behavior for selecting NpgsqlSequentialStringValueGenerator for string types is covered by tests.
var t when t == typeof(string) && property.ValueGenerated is not ValueGenerated.Never && property.GetDefaultValueSql() is null

@roji roji disabled auto-merge February 14, 2025 22:25
@roji roji force-pushed the StringGuid branch 2 times, most recently from 9653b50 to 80789b0 Compare February 14, 2025 22:44
@roji roji merged commit 16841f9 into npgsql:main Feb 14, 2025
16 of 17 checks passed
@roji roji deleted the StringGuid branch February 14, 2025 23:24
roji added a commit that referenced this pull request Feb 14, 2025
@roji
Copy link
Member Author

roji commented Feb 14, 2025

Backported to 9.0.4 via 953ad1c

roji added a commit that referenced this pull request Mar 1, 2025
This was referenced Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UUID Generation Still v4 Instead of v7 After Upgrading to .NET 9 / EF Core 9

1 participant